Re: [PATCH 02/13] dm: kill dm_rq_bio_destructor -- Fedora Linux Users


Re: [PATCH 02/13] dm: kill dm_rq_bio_destructor
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 02/13] dm: kill dm_rq_bio_destructor
From: Alasdair G Kergon <agk@xxxxxxxxxx>
Date: Fri, 18 May 2012 17:43:19 +0100
Cc: axboe@xxxxxxxxx, koverstreet@xxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Junichi Nomura <j-nomura@xxxxxxxxxxxxx>, linux-bcache@xxxxxxxxxxxxxxx, Mikulas Patocka <mpatocka@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, agk@xxxxxxxxxx
In-reply-to: <20120518155729.GB19388@google.com>
Mail-followup-to: Tejun Heo <tj@xxxxxxxxxx>, koverstreet@xxxxxxxxxx, axboe@xxxxxxxxx, dm-devel@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, agk@xxxxxxxxxx, Junichi Nomura <j-nomura@xxxxxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>
Organization: Red Hat UK Ltd. Registered in England and Wales, number 03798903. Registered Office: 64 Baker Street, 4th floor, London, W1U 7DF.
References: <cover.1337308722.git.koverstreet@google.com> <f07bc0f57562d98078e0f4c507cae165aa159e7c.1337308722.git.koverstreet@google.com> <20120518155729.GB19388@google.com>
Reply-to: device-mapper development <dm-devel@xxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)

On Fri, May 18, 2012 at 08:57:29AM -0700, Tejun Heo wrote:
> Please explain why this is done and how it's safe.  Alasdair / dm
> folks, can you please ack this?

I think it's relying on there being never more than one reference on those 
bios so that that endio fn, called exactly once, always frees it and there
are no dm_puts elsewhere.

Alasdair

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: [PATCH 02/13] dm: kill dm_rq_bio_destructor
  - From: Kent Overstreet

References:
- [PATCH 00/13] Block cleanups (for bcache)
  - From: koverstreet
- [PATCH 02/13] dm: kill dm_rq_bio_destructor
  - From: koverstreet
- Re: [PATCH 02/13] dm: kill dm_rq_bio_destructor
  - From: Tejun Heo

Prev by Date: Re: [PATCH 09/13] block: Add an explicit bio flag for bios that own their bvec
Next by Date: Re: [PATCH 04/13] block: Add bio_clone_kmalloc()
Previous by thread: Re: [PATCH 02/13] dm: kill dm_rq_bio_destructor
Next by thread: Re: [PATCH 02/13] dm: kill dm_rq_bio_destructor
Index(es):
- Date
- Thread

[DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [Yosemite Photos] [KDE Users] [Fedora Tools] [Fedora Docs]