Re: [PATCH 0/3][RESEND]multipath-tools: mpathpersist utility for managing persistent reservation on dm multipath device.
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On Saturday, February 11, 2012 2:13 PM, Christophe Varoqui wrote: > > On ven., 2012-02-10 at 18:47 +0000, Chauhan, Vijay wrote: > > git://github.com/vijaychauhan/multipath-tools.git > > Ok. This repo is merged. > Thanks. > I had to add a small build fix. Can you verify it's correctness ? > Yes, this fix is fine. > Are you sure the -H (hex) flag is used ? gcc reports the flag as > unused. > If it's not used I think you should either remove it from the usage > message and man or add the feature. > I will correct it. Thanks for pointing it out. > On the same topic: > in mpathpersist, > main.c:403:7: attention : variable ‘t_arr_len’ set but not used > [-Wunused-but-set-variable] > > and in libmpathpersist, > mpath_persist.c: In function ‘mpath_send_prin_activepath’: > mpath_persist.c:397:20: attention : variable ‘param’ set but not used > [-Wunused-but-set-variable] > mpath_persist.c: In function ‘mpath_prout_common’: > mpath_persist.c:553:15: attention : variable ‘pptemp’ set but not used > [-Wunused-but-set-variable] > mpath_pr_ioctl.c: In function ‘dumpHex’: > mpath_pr_ioctl.c:519:15: attention : variable ‘formatstr’ set but not > used [-Wunused-but-set-variable] > I will clean up these. > > Also I though sg_persist has IN mode set as default, so that simple > commands are simple to write : sg_persist -r /dev/sda. Can we restore > that nice feature ? > Yes, This would be a nice feature. I will submit the patch for all of your above comments. Thanks for your review. > Anyway, thanks for the great work. Thanks, Vijay -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel