Re: [PATCH 07/11] [dm-thin] Commit every second to prevent too much of a position building up.
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On Fri, Feb 10 2012 at 9:48am -0500, Joe Thornber <thornber@xxxxxxxxxx> wrote: > On Tue, Feb 07, 2012 at 11:53:25AM -0500, Mike Snitzer wrote: > > Shouldn't this be: > > > > if (bio_list_empty(&bios) || !need_commit_due_to_time(pool)) > > return; > > > > ? > > I don't think so. It's saying 'if <there's no reason to commit>'. The reasons to commit are bios being non-empty or need_commit_due_to_time. > > reason to commit = !bio_list_empty(&bios) || need_commit_due_to_time(pool) > !reason_to_commit = !(!bio_list_empty(&bios) || need_commit_due_to_time(pool)) > !reason_to_commit = (bio_list_empty(&bios) && !need_commit_due_to_time(pool)) > > Agree? Yeap, I followed up saying something like nevermind. > > Also, should we make the commit interval tunable (akin to ext's > > 'commit' mount option)? Or did you defer doing so until it proves > > worthwhile? > > y, tunable is on the list. Every second will do for now though. OK. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel