Re: [PATCH] block: add missing block_bio_complete() tracepoint

[Namhyung Kim <namhyung@xxxxxxxxx>]

2012-01-30 2:54 PM, Tejun Heo wrote:
> On Mon, Jan 30, 2012 at 02:51:43PM +0900, Namhyung Kim wrote:
> > Hi,
> >
> > 2012-01-30 11:53 AM, Tejun Heo wrote:
> > > Hello,
> > >
> > > On Mon, Jan 30, 2012 at 11:49:43 AM +0900, Namhyung Kim wrote:
> > > > Yes, blktrace will see both of completions for rq and bio's it
> > > > contains from now on, and I thought it's your intention? For the
> > > > bounced bio's, it'll see one more completion per bio.
> > >
> > > Umm... no, blktrace users shouldn't see confusing outputs.  My point
> > > was that we should leave raw tracepoints as raw monitor points so that
> > > they can provide raw data to different users and filter from
> > > blktrace.c so that the existing users aren't disturbed.
> >
> > That means blktrace should not be changed, and not see duplicated
> > completions for rq based drivers at all?
>
> Yeap

I see. I'll prepare the patch soon.

Thanks,
Namhyung

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel