Re: [PATCH] block: add missing block_bio_complete() tracepoint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


2012-01-30 10:47 AM, Tejun Heo wrote:
On Mon, Jan 30, 2012 at 10:44:19 AM +0900, Namhyung Kim wrote:
The userland tool cannot distinguish bounced bio from original one
at completion TP, but it can expect there will be a duplicated
BLK_TA_COMPLETE as it sees BLK_TA_BOUNCE for the bio before.

Filtering it out from kernel side seems to hide a real information
that (paranoid?) user might want to get, and it looks like providing
"polcy not mechanism" IMHO. That's why I changed my mind finally.

I cannot think of the downside, anyway it's not a big deal, if you
think it's wrong choice, I'm OK to change it again.

It's just that this patch as it stands will break the existing tools
and is likely to cause some amount of head scratching for blktrace
users upgrading to new kernel with existing userland, so yeah, I think
it should be filtered in kernel from blktrace.c.

Thanks.


Will it break blktrace? Looking at the code, not tested though, it will just add one more 'C' line for bounced bio, and that's it? The blktrace will get way more 'C' lines for normal request based devices and it needs to be handled anyway. Am I missing something?

Thanks,
Namhyung

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel


[DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]     [Fedora Docs]

Add to Google Powered by Linux