Re: [PATCH] dm-thin: Fix multiple bugs with reference management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Mon, Sep 12, 2011 at 12:03:31PM -0400, Mikulas Patocka wrote:
> Hi
> This is a major cleanup+bugfix of reference count management. Test it with 
> your testsuite.

Right, we've got 2 patches here really.

The first replaces a spinlock with a mutex and lifts it to remove a
couple of race conditions.  All good, I've prefixed the functions that
should be called with this lock held with '__' as usual.

The second moves registration to the constructor and destructor rather
than suspend/resume.  I know you were asking about this earlier, and I
think this was a hang over from when the pool and target objects were
the same thing, and we couldn't have two targets registered at once
when reloading a table.  Your change is clearly simpler.

All tests pass.  Merged and pushed.


- Joe

dm-devel mailing list

[DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]     [Fedora Docs]

Add to Google Powered by Linux