Re: [PATCH 14/37] dccp: Tidy up setsockopt calls

["Eugene Teo" <eugeneteo@xxxxxxxxx>]

On Fri, Aug 29, 2008 at 1:44 AM, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
[...]
> +       default:
> +               if (optlen < sizeof(int))
> +                       return -EINVAL;

Although it is already checked in sys_setsockopt(), it's probably good
to change this to:

               if (optlen < (int)sizeof(int))
                       return -EINVAL;

Reviewed-by: Eugene Teo <eugeneteo@xxxxxxxxx>

Thanks, Eugene
--
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html