- Subject: Re: [PATCH] Avoid imaxdiv when only one of the results is wanted
- From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 17 Aug 2011 09:27:52 +0800
- Cc: dash@xxxxxxxxxxxxxxx
- In-reply-to: <1311635376.10727.8.camel@linux>
- User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jul 25, 2011 at 11:09:36PM +0000, Harald van Dijk wrote:
> dash rather pointlessly calls imaxdiv, only to discard one of its
> results. The call was already made conditional a while back because some
> systems don't have imaxdiv, but the generated code for the version with
> imaxdiv and the one with / and % is identical (with GCC 4.6.1 or ICC
> 12.0.2, with -O0, -O2 or -Os), so it could just as well go entirely to
> clean up the code a little bit.
>
> Signed-off-by: Harald van Dijk <harald@xxxxxxxxxxx>
Nice work, patch applied.
Thanks!
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[LARTC]
[Bugtraq]
[Yosemite Forum]
[Photo]