Re: [PATCH] fix two compile time warnings

[Maciej Åenczykowski <zenczykowski@xxxxxxxxx>]

>> That's unfortunate since it prevents a -Werror build of klibc (which
>> includes dash) from succeeding.
>
> And that's precisely why I would never use -Werror with gcc.

My personal experience has been that the warnings gcc produces are far
more often a sign of real bugs
than they are spurious.  Usually fixing them isn't particularly bothersome.

(although this is based on experience predominantly gained not on klibc or dash)

> You can always apply this patch in klibc locally.

I do, however, I prefer submitting patches upstream whenever possible.

I'll continue to maintain this one locally.

- Maciej
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html