- Subject: Re: [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver
- From: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
- Date: Fri, 23 Dec 2011 13:18:51 +0000
- Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, cpufreq@xxxxxxxxxxxxxxx, devicetree-discuss@xxxxxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxxx, davej@xxxxxxxxxx, grant.likely@xxxxxxxxxxxx, rob.herring@xxxxxxxxxxx, rdunlap@xxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx, shawn.guo@xxxxxxxxxx, catalin.marinas@xxxxxxx, eric.miao@xxxxxxxxxx, mark.langsdorf@xxxxxxxxxxx, davidb@xxxxxxxxxxxxxx, arnd@xxxxxxxx, bryanh@xxxxxxxxxxxxxx, jamie@xxxxxxxxxxxxx, marc.zyngier@xxxxxxx, linaro-dev@xxxxxxxxxxxxxxxx, patches@xxxxxxxxxx
- In-reply-to: <1324537753-30590-5-git-send-email-richard.zhao@linaro.org>
- References: <1324537753-30590-1-git-send-email-richard.zhao@linaro.org> <1324537753-30590-5-git-send-email-richard.zhao@linaro.org>
- User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Dec 22, 2011 at 03:09:10PM +0800, Richard Zhao wrote:
> The driver get cpu operation point table from device tree cpu0 node,
> and adjusts operating points using clk and regulator APIs.
Reviewed-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
but one nit:
> +Required properties in /cpus/cpu@0:
> +- cpu-freqs : cpu frequency points it support, in unit of Hz.
> +- cpu-volts : cpu voltages required by the frequency point at the same index,
> + in unit of uV.
> +- trans-latency : transition_latency, in unit of ns.
trans-latency should really say what latency is being measured (the CPU
core only or the whole operation).
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]