Re: [cpupower] RFC: use man(1) when calling "cpupower help subcommand"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



y
On Wed, Aug 10, 2011 at 08:53:53AM +0200, Thomas Renninger wrote:
> On Saturday 06 August 2011 18:11:43 Dominik Brodowski wrote:
> > Instead of printing something non-formatted to stdout, call
> > man(1) to show the man page for the proper subcommand.
> 
> Nice!
>   
> > -extern void set_help(void);
> > -extern void info_help(void);
> > -extern void freq_set_help(void);
> > -extern void freq_info_help(void);
> > -extern void idle_info_help(void);
> > -extern void monitor_help(void);
> I wonder whether these are still needed then.
> If they can get removed translations, maintenance overhead
> (adjusting 2 places when adding a parameter) and the size of the 
> binaries could get reduced.

That's enough material for a second patch, which cleans up the error paths
on invalid or insufficient parameters being passed to the (sub)commands.

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux