Re: [PATCH 1/4] S3C: CPU detection support

[Andy Green <andy@xxxxxxxxxxx>]

Somebody in the thread at some point said:
> On Mon, Mar 09, 2009 at 07:13:54PM +0000, Andy Green wrote:
>
> > We set system_rev from an ATAG in our bootloader.... this trashes that  
> > for us.
>
> > Is what we're doing there wrong or is overwriting system_rev here wrong?
>
> That's an issue that was raised with the patch previously - see the
> thread:
>
> 	http://www.spinics.net/lists/arm-kernel/msg62218.html
>
> I'd say you're not doing anything wrong and the patch should be updated.

In the meanwhile I adapted the patch slightly to keep the low 16 bits 
from the ATAG, since it doesn't use them itself, and added some access 
#defines to get the CPU type part or the ATAG part and changed the dozen 
or so places in our code using system_rev to use those access defines.

I'm sure that won't satisfy anyone :-) but it lets me get on for now.

-Andy

--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html