Re: [PATCH 4/5] Use install instead of cp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]




On 03/21/2012 05:23 PM, Jan Friesse wrote:
> Not all cp implementations support -a parameter, and install is better
> suited for "preserve attributes" behavior.
> 
> Signed-off-by: Jan Friesse <jfriesse@xxxxxxxxxx>
> ---
>  exec/Makefile.am |    2 +-
>  lib/Makefile.am  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/exec/Makefile.am b/exec/Makefile.am
> index 1d07d8d..ddb41e1 100644
> --- a/exec/Makefile.am
> +++ b/exec/Makefile.am
> @@ -158,7 +158,7 @@ all-local: $(LCRSO_OBJS) $(LCRSO) $(SHARED_LIBS)
>  install-exec-local:
>  	$(INSTALL) -d $(DESTDIR)/$(libdir)
>  	$(INSTALL) -m 755 $(SHARED_LIBS) $(DESTDIR)/$(libdir)
> -	$(CP) -a $(SHARED_LIBS_SO) $(SHARED_LIBS_SO_TWO) $(DESTDIR)/$(libdir)
> +	$(INSTALL) $(SHARED_LIBS_SO) $(SHARED_LIBS_SO_TWO) $(DESTDIR)/$(libdir)

Hold on a second on this one... the reason why we used CP instead of
INSTALL is because at the time, INSTALL failed to copy symlinks as such
and made a real copy of the .so* in /usr/lib..

So unless INSTALL is fixed, then we can't use it. .so are expected to be
symlinks.

Fabio
_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Corosync Project]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux