|
|
|
Re: [PATCH] Add no_addrs field in srp_addr structure | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
The change looks good minus all the debugging
Reviewed-by: Steven Dake <sdake@xxxxxxxxxx>
On 03/22/2012 06:02 AM, Jan Friesse wrote:
> Steven Dake napsal(a):
>> On 03/20/2012 07:35 AM, Jan Friesse wrote:
>>> This should allow us future change to dynamic number of rings without
>>> breaking wire compatibility.
>>>
>>> Signed-off-by: Jan Friesse <jfriesse@xxxxxxxxxx>
>>> ---
>>> exec/totemsrp.c | 3 +++
>>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/exec/totemsrp.c b/exec/totemsrp.c
>>> index c262d98..dc93cc2 100644
>>> --- a/exec/totemsrp.c
>>> +++ b/exec/totemsrp.c
>>> @@ -153,6 +153,7 @@ enum encapsulation_type {
>>> * New membership algorithm local variables
>>> */
>>> struct srp_addr {
>>> + uint8_t no_addrs;
>>> struct totem_ip_address addr[INTERFACE_MAX];
>>> };
>>>
>>> @@ -677,6 +678,8 @@ static void totemsrp_instance_initialize (struct
>>> totemsrp_instance *instance)
>>> instance->orf_token_discard = 0;
>>>
>>> instance->commit_token = (struct memb_commit_token
>>> *)instance->commit_token_storage;
>>> +
>>> + instance->my_id.no_addrs = INTERFACE_MAX;
>>> }
>>>
>>> static void main_token_seqid_get (
>>
>> Did you test that all received messages that use the srp_addr struct
>> have no_addrs set to 2? If so, then
>>
>
> Thanks for notice. Previous patch correctly set no_addrs for my_id, but
> it was not copied in outgoing packets. Attached is better patch, which
> solves this problem (as can be seen in memb_set_print) (better patch
> pushed to master).
>
> Honza
>
>> Reviewed-by: Steven Dake <sdake@xxxxxxxxxx>
>>
>> Regards
>> -steve
>
_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss
|
|