Re: [PATCH 4/5] Use install instead of cp

[Steven Dake <sdake@xxxxxxxxxx>]

Reviewed-by: Steven Dake <sdake@xxxxxxxxxx>

On 03/21/2012 09:23 AM, Jan Friesse wrote:
> Not all cp implementations support -a parameter, and install is better
> suited for "preserve attributes" behavior.
> 
> Signed-off-by: Jan Friesse <jfriesse@xxxxxxxxxx>
> ---
>  exec/Makefile.am |    2 +-
>  lib/Makefile.am  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/exec/Makefile.am b/exec/Makefile.am
> index 1d07d8d..ddb41e1 100644
> --- a/exec/Makefile.am
> +++ b/exec/Makefile.am
> @@ -158,7 +158,7 @@ all-local: $(LCRSO_OBJS) $(LCRSO) $(SHARED_LIBS)
>  install-exec-local:
>  	$(INSTALL) -d $(DESTDIR)/$(libdir)
>  	$(INSTALL) -m 755 $(SHARED_LIBS) $(DESTDIR)/$(libdir)
> -	$(CP) -a $(SHARED_LIBS_SO) $(SHARED_LIBS_SO_TWO) $(DESTDIR)/$(libdir)
> +	$(INSTALL) $(SHARED_LIBS_SO) $(SHARED_LIBS_SO_TWO) $(DESTDIR)/$(libdir)
>  	$(INSTALL) -d $(DESTDIR)/$(LCRSODIR)
>  	$(INSTALL) -m 755 $(LCRSO) $(DESTDIR)/$(LCRSODIR)
>  
> diff --git a/lib/Makefile.am b/lib/Makefile.am
> index 5b33e24..d3e417a 100644
> --- a/lib/Makefile.am
> +++ b/lib/Makefile.am
> @@ -129,7 +129,7 @@ all-local: $(get_explicit_sharedlibs) $(SHARED_LIBS_SO)
>  install-exec-local:
>  	$(INSTALL) -d $(DESTDIR)/$(libdir)
>  	$(INSTALL) -m 755 $(get_sharedlibs) $(get_explicit_sharedlibs) $(DESTDIR)/$(libdir)
> -	$(CP) -a $(SHARED_LIBS_SO) $(EXPLICIT_SHARED_LIBS_SO) $(get_sharedlibs_two) $(get_explicit_sharedlibs_two) $(DESTDIR)/$(libdir)
> +	$(INSTALL) $(SHARED_LIBS_SO) $(EXPLICIT_SHARED_LIBS_SO) $(get_sharedlibs_two) $(get_explicit_sharedlibs_two) $(DESTDIR)/$(libdir)
>  
>  uninstall-local:
>  	cd $(DESTDIR)/$(libdir)/ && \

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss