Re: [PATCH 3/3] onecrypt: move encryption code to crypto.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]




ACK with minor caveats...


> diff --git a/exec/crypto.c b/exec/crypto.c
> new file mode 100644
> index 0000000..6c15bb6
> --- /dev/null
> +++ b/exec/crypto.c
> @@ -0,0 +1,543 @@
> +/*
> + * Copyright (c) 2006-2012 Red Hat, Inc.
> + *
> + * All rights reserved.
> + *
> + * Author: Steven Dake (sdake@xxxxxxxxxx)

^^^^^ date and author needs fixing.


> diff --git a/exec/crypto.h b/exec/crypto.h
> new file mode 100644
> index 0000000..f80bcf7
> --- /dev/null
> +++ b/exec/crypto.h
> @@ -0,0 +1,75 @@
> +/*
> + * Copyright (c) 2006-2011 Red Hat, Inc.
> + *
> + * All rights reserved.
> + *
> + * Author: Steven Dake (sdake@xxxxxxxxxx)

same here

Everything else looks fine.

As we already discussed, we can cleanup some of the code at a later
stage and avoid exporting that many data from crypto to totem.

Fabio
_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Corosync Project]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux