Re: [PATCH] sync: kill evil and syncv1 in one shot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fabio,
please send another patch which updates man page (removal of compatibility flag). Other then that (and when resolved problems found be Steve):

Reviewed-by: Jan Friesse <jfriesse@xxxxxxxxxx>

Steven Dake napsal(a):
On 03/07/2012 03:44 AM, Jan Friesse wrote:
Fabio,
my call there is give it a proper test and commit, because these all
compatibility things are meaningless anyway, unused, untested,
unmaintained, ..., and it's better to break RC2 x RC1, then break 2.1 x
2.0.

But I would like to have some consensus there, so wait also for Steve
(at least).


Rather break now then later.  We should be guaranteeing X on-wire
compatibility, Ie everything in 2.Y should communicate.  Therefore if we
held up this change, we would have to wait until 3.0.  I would like two
reviewed-by on this patch.  I'll wrap up a review today, perhaps honza
you can also provide a review by.

We can release a new release candidate next week, and push the schedule
out past the 15th if we need as a result.

Regards
-steve

Honza

Fabio M. Di Nitto napsal(a):
From: "Fabio M. Di Nitto"<fdinitto@xxxxxxxxxx>

Signed-off-by: Fabio M. Di Nitto<fdinitto@xxxxxxxxxx>
---
  exec/Makefile.am            |    8 +-
  exec/apidef.c               |    1 -
  exec/cfg.c                  |    3 +-
  exec/cpg.c                  |    7 +-
  exec/evil.c                 |  540 -------------------------------
  exec/evil.h                 |   55 ----
  exec/evs.c                  |    3 +-
  exec/ipc_glue.c             |   43 ---
  exec/main.c                 |  113 +------
  exec/mainconfig.c           |   31 --
  exec/mainconfig.h           |    4 -
  exec/mon.c                  |    3 +-
  exec/pload.c                |    3 +-
  exec/quorum.c               |    1 -
  exec/sync.c                 |  744
+++++++++++++++++++++++++------------------
  exec/sync.h                 |   45 +--
  exec/syncv2.c               |  623 ------------------------------------
  exec/syncv2.h               |   62 ----
  exec/util.c                 |   15 +-
...

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux