Re: [PATCH] Advertise Telephony service class when device offers headset AG or handsfree AG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Sat, Aug 30, 2008 at 2:28 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
Hi Nick,

>         >  src/sdpd-service.c |    2 ++
>         >  1 files changed, 2 insertions(+), 0 deletions(-)
>         >
>         > diff --git a/src/sdpd-service.c b/src/sdpd-service.c
>         > index cf120b8..df9017e 100644
>         > --- a/src/sdpd-service.c
>         > +++ b/src/sdpd-service.c
>         > @@ -125,6 +125,8 @@ static void update_svclass_list(void)
>         >               case INTERCOM_SVCLASS_ID:
>         >               case FAX_SVCLASS_ID:
>         >               case SAP_SVCLASS_ID:
>         > +             case HEADSET_AGW_SVCLASS_ID:
>         > +             case HANDSFREE_AGW_SVCLASS_ID:
>         >                       val |= 0x40;    /* Telephony */
>         >                       break;
>         >               case AUDIO_SOURCE_SVCLASS_ID:
>         do you have a reference to a spec. for this one. The automatic
>         service
>         class adjustment has been done according to the spec.
> I didn't even know there existed a spec for these service classes. I
> thought they were rather arbitrary. But it certainly makes sense that
> if offer headset or handsfree audio gateway you are a telephone.

you wish, but it doesn't work this way. Every profile spec. clearly
states which service classes have to enabled for every role. Like it
clearly shows how the SDP record has to look.

I spent quite some time getting this done so no developer has to worry
about service classes anymore. So I really need the reference from the
headset and hansfree specs. before I touch this.

So I looked at the headset and handsfree spec, they do not require that AG's set the telephony bit. sigh.

But I can tell you for a fact that the Nokia 616 carkit will not pair unless you set the telephony bit. That is what triggered this patch.

We have yet to find a device (and we have tested hundreds now) that is not compatible because of the telephony bit. It is a safe change to make.

So sure, you can reject the patch on the basis that it is not mandated by the specification. But if you care about compatibility then it seems like a good change to make. Especially since you now ignore the service class in hcid.conf so there is no easy way to override.


This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
Bluez-devel mailing list

[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux