On Wednesday, January 22, 2014 06:11 PM, Russell King - ARM Linux wrote:
I agree, and this patch should not apply to the kernel,, . Its my fix for my production mainboard only. I report the Oops but not get any response back. I'm sorry to wast your time.On Wed, Jan 22, 2014 at 12:32:39PM +0800, Chris Ruehl wrote:diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c index f7199c8..8645d6a 100644 --- a/drivers/mmc/host/mxcmmc.c +++ b/drivers/mmc/host/mxcmmc.c @@ -347,7 +347,7 @@ static int mxcmci_setup_data(struct mxcmci_host *host, struct mmc_data *data) return 0;for_each_sg(data->sg, sg, data->sg_len, i) {- if (sg->offset & 3 || sg->length & 3 || sg->length < 512) { + if (sg && (sg->offset & 3 || sg->length & 3 || sg->length < 512)) {sg should never be NULL here - so this is probably papering over a bug.
Chris _______________________________________________ linux-arm mailing list linux-arm@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm
- References:
- [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset
- From: Chris Ruehl
- Re: [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset
- From: Russell King - ARM Linux
- [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset
- Prev by Date: Re: [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset
- Next by Date: Re: [PATCH 1/2 v2] imx27: pinctrl: fix wrong offset to ICONFB
- Previous by thread: Re: [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset
- Next by thread: Re: [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset
- Index(es):