Re: [PATCH] OMAP: Serial: Define register access modes in LCR

[Greg KH <greg@xxxxxxxxx>]

On Wed, Nov 17, 2010 at 09:28:52AM -0800, Kevin Hilman wrote:
> Greg KH <greg@xxxxxxxxx> writes:
> 
> > On Wed, Nov 17, 2010 at 10:31:52AM +0200, Emeltchenko Andrei wrote:
> >> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> >> 
> >> Access to some registers depends on register access mode
> >> Three different modes are available for OMAP (at least)
> >> â Operational mode     LCR_REG[7] = 0x0
> >> â Configuration mode A LCR_REG[7] = 0x1 and LCR_REG[7:0]! = 0xBF
> >> â Configuration mode B LCR_REG[7] = 0x1 and LCR_REG[7:0]  = 0xBF
> >> 
> >> Define access modes and remove redefinitions and magic numbers
> >> in serial drivers (and later in bluetooth driver).
> >> 
> >> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> >> ---
> >>  arch/arm/mach-omap2/serial.c                  |   12 ++++----
> >>  arch/arm/plat-omap/include/plat/omap-serial.h |    9 ------
> >>  drivers/serial/8250.c                         |   26 +++++++++---------
> >>  drivers/serial/omap-serial.c                  |   34 ++++++++++++------------
> >>  include/linux/serial_reg.h                    |    7 +++++
> >
> > What tree should this go through?  THe omap or serial one?
> 
> Since this only affects OMAP drivers, we can take this through OMAP.
> 
> That will also help us avoid conflicts, as we'll hopefully be converting
> the omap-serial driver to runtime PM for this next merge window as well.

Fine with me, feel free to add:
	Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

to it.

thanks,

greg k-h

_______________________________________________
linux-arm mailing list
linux-arm@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm