Re: ep93xx gpio interrupt debounce

[Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx>]

On Tue, Apr 22, 2008 at 11:00:20PM -0400, hartleys wrote:

> The patch below adds debouncing support to the ep93xx GPIO interrupts.
> 
> Please review and let me know if it looks okay.

Ah.  This looks very similar to the patch I wrote for it originally.

And I remember now why I never submitted it for merging:


> Index: src/working/linux-2.6.25/include/asm-arm/irq.h
> ===================================================================
> --- src.orig/working/linux-2.6.25/include/asm-arm/irq.h	2008-04-22
> 19:57:08.000000000 -0700
> +++ src/working/linux-2.6.25/include/asm-arm/irq.h	2008-04-22
> 19:58:03.000000000 -0700
> @@ -35,6 +35,7 @@
>  #define IRQT_LOW	(__IRQT_LOWLVL)
>  #define IRQT_HIGH	(__IRQT_HIGHLVL)
>  #define IRQT_PROBE	IRQ_TYPE_PROBE
> +#define IRQT_DEBOUNCE	(1 << 5)
>  
>  #ifndef __ASSEMBLY__
>  struct irqaction; 

I'm not happy with this part -- it seems wrong to add a IRQT_* for
something that is only used on one particular SoC.

Then again, the ->set_type() API _is_ IMHO the place where debounce
should be handled.

So.. I don't know what to do with this, basically.

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php