Re: [PATCH] Kirkwood: Don't initialize Marvell RTC for all boards

[Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>]

On Mon, Mar 23, 2009 at 10:52:35AM -0400, Nicolas Pitre wrote:
> On Sun, 22 Mar 2009, Martin Michlmayr wrote:
> 
> > Even though the Marvell Kirkwood has a built-in RTC, some Kirkwood
> > based boards (e.g. QNAP TS-219) use a separate RTC chip.  Don't
> > initialize the Marvell RTC in common code for all boards, otherwise
> > you end up with two RTC devices on those with their own RTC chip
> > and the default device is the Marvell RTC which may not work.
> 
> Bah...  Well, given that the majority of Kirkwood designs are likely to 
> use the internal RTC since it is already there (why pay for a separate 
> one if you already get it in the SOC), I'd suggest that this patch be 
> made to work in the opposite direction: instead of having every other 
> Kirkwood boards registering the RTC themselves, I'd suggest that the 
> TS-219 code unregisters the internal RTC device instead.

However, you can't unregister platform devices that are statically
allocated, so you can't unregister the internal RTC device.

A better solution would be to fix the f$"%$#" RTC subsystem so that
platforms can specify the default RTC device, as has been previously
discussed on this list.

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php