Re: [PATCH 1/3] S3C: CPU detection support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Thu, Feb 26, 2009 at 07:59:44PM +0000, Mark Brown wrote:
> +extern unsigned int system_rev;
> +
> +/*
> + * cpu_is_s3c24xx():	True for s3c2400, s3c2410, s3c2440 and so on
> + * cpu_is_s3c241x():	True fro s3c2410, s3c2412
> + * cpu_is_s3c244x():	True fro s3c2440, s3c2442, s3c2443
> + * cpu_is_s3c64xx():	True for s3c6400, s3c6410
> + */
> +#define GET_S3C_CLASS	((system_rev >> 24) & 0xff)

I think OMAP people decided in the end that using 'system_rev' for the
SoC was wrong.  'system_rev' was added for NetWinders so that the board
level hardware version could be given to the kernel.

They've since moved over to a different approach, and storing the SoC
revision in their own private omap_revision variable.

Is this something s3c should also consider?

List admin:

[Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Fedora ARM]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [PDAs]     [Linux]     [Linux Book List]     [Linux MIPS]     [Yosemite Campsites]     [Photos]

Add to Google Follow linuxarm on Twitter