Re: [Pull Request] Eseries patches

[Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>]

On Sun, Sep 07, 2008 at 02:18:29PM +0100, Ian Molton wrote:
> Russell King - ARM Linux wrote:
> 
> >> Hehe, it looks like Russell has more strict requirement on this.
> >> I guess you have to merge them a bit further and do more work :)
> 
> No, Russell just silently merged them, but they didnt hit mainline yet

Well, of course they haven't hit mainline yet.  They're not -rc material.

> > The problem is that Ian's been bugging me to merge the reshuffle of
> > the eseries stuff, and whining "where are you" to several of my email
> > addresses.
> 
> Well when you dont reply for several days, what should I do? sit here
> and wait longer?

How about you actually check my published tree once in a while to make
sure what you want there is there, and it's there in the right state?

Which is *precisely* what I have to do with Linus' tree.

> and its your own fault I had to do that twice because as you pointed
> out to me, you willfully ignored one of my messages (your choice of word).

Of course it's my fault for you not checking whether it's been pulled.

> I've had a play, and the best I can come up with is to use gitk --all
> and search for my name until I find either the specific patchset, or
> one that predates it.

git diff mybranch...yourbranch

If empty, it's been merged.

> >  Fact is, the last pull was 26th August before these subsequent
> > "where are you" "pull my tree" whinges started.
> 
> Would have been nice if you said something as simple as "I pulled your
> tree on XXX, are you sure there are any changes" then (using polite
> language, not the rather arrogant didactic message I got).

When I send Linus a message asking him to pull my tree, the *only*
response I get is when it appears in mainline.  There's no "I've
pulled it" response from Linus.

And if I keep bothering him like you do with me, I get an extremely
hot roasting from Linus.  I know, I've been on the receiving end.

Five messages between 19th and 28th August concerning pulling these
changes - that's an average of one every two days.  Don't you think
that's excessive?

Also, bear in mind that whenever I send a pull request to Linus, it's
_always_ formatted how Linus wants it.  Never is a short "please pull
this URL".  Missing out things like the diffstat is a recipe for being
ignored, or being flamed by Linus.  Even if he missed a pull request.
It still has to be formatted to his liking.

So why is it seemingly unreasonable for me to require the same thing
about your pull requests?  Why is it soo difficult for you to provide
the information I ask for?  Why do you always have to question such
requests?

> > I've no idea what's actually in Ian's tree and what he's asking me to
> > actually pull.  There's no diffstat, no list of changes, and no gitweb
> > URL.  I've no real idea if what he's asking me to pull is just the
> > stuff which I pulled on the 26th but now rebased.
> 
> Simply because, since I believed the branch not to have been pulled,
> I didn't think it was necessary to post an identical diffstat. If I
> thought it had been pulled I wouldn't have even had to send a pull
> request would I?

Your choice to limit the available information.  Your choice not to put
in your message "this is a repeat of the request on such-and-such" both
of which would've made it completely clear, rather than me having to
guess.

And you're in this situation precisely because of your attitude towards
my requests to provide better formatted pull requests.

> Since it was obvious that I was pushing the same patchset I already
> pushed (I said as much in my second pull request) you might have
> simply said so.

Oh, it's obvious is it?  I'm sorry, I should've consulted my crystal
ball which would've told me.  Get real Ian.

> Have a nice day Russell. You've got a reputation for this kind of 'rubbing
> peoples nose in their errors' crap by now, hope it doesn't bite you.

Well, that just shows what kind of person you are...

As for your claim that you sent a pull request with a diffstat in earlier,
I see *no* evidence of that having been done *ever* for this set, unlike
your claims.  I've gone back to 21st August, no diffstat for the 'for_rmk'
branch.  The only one I can find is on the 19th August which was for the
'for_rmk_17' branch.

So.  Again.  This time in big letters to make my request absolutely
clear.

	IF YOU WANT ME TO PULL YOUR TREE, PLEASE SEND PROPERLY
	FORMATTED PULL REQUESTS, EVERY TIME, AS I ALREADY REQUESTED.

And yes, I've tried asking for that politely, and evidence is that it
doesn't work.

Finally, note that my original plan was to be away from 20th to 31st
August.  Do you think that I want a mailbox full of people whining
"RMK - Where are you?"

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php