Re: [PATCH 0/7] poodle/corgi/spitz: extended GPIO conversion

["Eric Miao" <eric.y.miao@xxxxxxxxx>]

On Sun, Sep 7, 2008 at 4:33 PM, Dmitry <dbaryshkov@xxxxxxxxx> wrote:
> 2008/9/7 Eric Miao <eric.y.miao@xxxxxxxxx>:
>> 1. dropping of leds-{corgi, spitz}.c is merged into the patch of corgi/spitz
>> converted to use leds-gpio.
>
> Preferred to keep them apart as they should be merged into different trees.
>

I'd prefer Richard's Ack on this and merged as one patch
through one tree to avoid the merge dependency issue.

>>
>> 2. to simplify the conversion, gpio_{request,free}() of some GPIOs are
>> not added (depends on implied request), and left for future improvement.
>
> No! Implied requests are bad! And why "leave for future improvement" if it can
> be done now? I'd say it's really a step in the incorrect direction.
>

I'm going to make this quicker. I don't have enough time to look
into every GPIO dedicating for what, and when, and where is
appropriate to place the request/free code.

Should you have correct solutions to this, please send patches
to me before the next merge window (please leave enough time
before the merge window, so that Russell won't complain) and
I'll merge them.

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php