Re: [PATCH 0/7] poodle/corgi/spitz: extended GPIO conversion

[Dmitry <dbaryshkov@xxxxxxxxx>]

2008/9/7 Eric Miao <eric.y.miao@xxxxxxxxx>:
> 1. dropping of leds-{corgi, spitz}.c is merged into the patch of corgi/spitz
> converted to use leds-gpio.

Preferred to keep them apart as they should be merged into different trees.

>
> 2. to simplify the conversion, gpio_{request,free}() of some GPIOs are
> not added (depends on implied request), and left for future improvement.

No! Implied requests are bad! And why "leave for future improvement" if it can
be done now? I'd say it's really a step in the incorrect direction.

>
> On Sun, Sep 7, 2008 at 1:00 PM, Eric Miao <eric.y.miao@xxxxxxxxx> wrote:
>> These patches are based on Dmitry's previous work at:
>>
>> git://git.infradead.org/users/dbaryshkov/zaurus-2.6.git scoop
>>
>> However, I'm still not quite satisfied with the introduction of
>> setup/teardown/suspend/resume callbacks to handle the
>> initial/suspend states of the GPIOs.
>>
>> I'd like to make this quicker and leave the above concern for future
>> improvement. I thus removed some modifications from the original
>> patch, and made only the necessary ones, which _only_ converted
>> the {set,reset}_scoop_gpio() to more appropriate gpio_set_value().
>>
>> --
>> Cheers
>> - eric
>>
>
>
>
> --
> Cheers
> - eric
>



-- 
With best wishes
Dmitry

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php