Re: [PATCH 0/n] Spitz/Akita changes

["Eric Miao" <eric.y.miao@xxxxxxxxx>]

On Sat, Sep 6, 2008 at 12:02 AM, Dmitry Baryshkov <dbaryshkov@xxxxxxxxx> wrote:
> On Wed, Aug 27, 2008 at 05:47:01PM +0400, Dmitry Baryshkov wrote:
>> On Wed, Aug 27, 2008 at 05:38:33PM +0400, Dmitry Baryshkov wrote:
>> > On Tue, Aug 26, 2008 at 01:37:08PM +0200, Stanislav Brabec wrote:
>> > > Dmitry wrote:
>> > > > 2008/8/26 Dmitry <dbaryshkov@xxxxxxxxx>:
>> > >
>> > > > > It's very strange: spitz_init _is_called for all spitz (i mean
>> > > > > non-akita :). Otherwise you won't get
>> > > > > any CF cards, etc.
>> > >
>> > > Confirming, it is called. It is called on a different place than it was
>> > > proposed in Mark's patch. That is why I tried to move it after
>> > > set_pxa_fb_info() and try again. It does not help. That is why I
>> > > suspect, that something is not properly initialized.
>> > >
>> > > > BTW: could you please provide the dmesg?
>> >
>> > Strange. Could you please stop revering the reset patch, apply three
>> > attached patches and post a dmesg.
>>
>> Oops... I definitely need more time to sleep. Please use attached one
>> instead of the one sent in the previous mail.
>
> Stanislav, could you please try the patch below instead of the povided
> previously one fixing resets? Thanks.
>
> --
> With best wishes
> Dmitry
>
> >From 185d53d38282493bf0df98ecf695525c0539b2a8 Mon Sep 17 00:00:00 2001
> From: Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>
> Date: Fri, 5 Sep 2008 19:56:28 +0400
> Subject: [PATCH] fixup spitz reset during boot
>
> Some machines don't have the pullup/down on their reset
> pin, so configuring the reset generating pin as input makes
> them reset immediately. Fix that by making reset pin direction
> configurable.
>
> Signed-off-by: Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>
> ---
>  arch/arm/mach-pxa/include/mach/reset.h |    9 ++++++---
>  arch/arm/mach-pxa/reset.c              |    9 ++++++---
>  arch/arm/mach-pxa/spitz.c              |    2 +-
>  arch/arm/mach-pxa/tosa.c               |    2 +-
>  4 files changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/include/mach/reset.h b/arch/arm/mach-pxa/include/mach/reset.h
> index 9489a48..7b8842c 100644
> --- a/arch/arm/mach-pxa/include/mach/reset.h
> +++ b/arch/arm/mach-pxa/include/mach/reset.h
> @@ -10,9 +10,12 @@
>  extern unsigned int reset_status;
>  extern void clear_reset_status(unsigned int mask);
>
> -/*
> - * register GPIO as reset generator
> +/**
> + * init_gpio_reset() - register GPIO as reset generator
> + *
> + * @gpio - gpio nr
> + * @output - set gpio as out/low instead of input during normal work
>  */
> -extern int init_gpio_reset(int gpio);
> +extern int init_gpio_reset(int gpio, int output);
>

I'd prefer this being defined as:

@inverted - nGPIO_RESET defaults to active low, set this
to "1" in case of external wiring logic negates the polarity

extern int init_gpio_reset(int gpio, int inverted);

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php