Re: PATCH: s3cmci, add support for non-word-sized transfers was S3C24XX: Documentation

[Christer Weinigel <christer@xxxxxxxxxxx>]

Ben Dooks wrote:
> On Thu, Aug 21, 2008 at 02:04:10PM +0200, Christer Weinigel wrote:
>> The next problem was that the s3cmci driver didn't have any support
>> for non-word-sized transfers.  I've changed the pio_words variable to
>> be pio_bytes instead and I think I've fixed up all the places where
>> it was used so that they do the right thing.  This makes SDIO Bluetooth
>> Type A work on the S3C24A0 based reference board we are using at work.

> Could you fix the signed-off-by lines (pref. make it one) and then
> resubmit with a proper description of this patch? I would like to get
> this submitted to Pierre for the next development window. I'll push
> this as-is into my own tree to play with.

I just realised that the code is a bit buggy, it will always write full 
dwords to memory, even when reading an odd number of bytes, so there is 
a potential buffer overrun in there.  I'll have to fix that first.

  /Christer

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php