Re: [Patch 2/3] Move SMC register setup for NAND

[Nicolas Ferre <nicolas.ferre@xxxxxxxxx>]

Hi Guillaume,

Guillaume GARDET :
> 
> Move SMC register setup for NAND out of at91sam9263_devices.c and into board-sam9263ek.c.
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@xxxxxxx>
> 
> diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c
> index c93992f..a7d4f7e 100644
> --- a/arch/arm/mach-at91/at91sam9263_devices.c
> +++ b/arch/arm/mach-at91/at91sam9263_devices.c
> @@ -382,7 +382,7 @@ static struct platform_device at91sam9263_nand_device = {

[..]

> diff --git a/arch/arm/mach-at91/board-sam9263ek.c b/arch/arm/mach-at91/board-sam9263ek.c
> index b1d1196..8855570 100644
> --- a/arch/arm/mach-at91/board-sam9263ek.c
> +++ b/arch/arm/mach-at91/board-sam9263ek.c

It seems that you are not modifying all the at91sam9263 related boards :
board-usb-a9263.c
is not modified. As you are changing the at91sam9263_devices.c, you need 
to provide a modification for this other also.

One more point : this modification is ok for me but I fear there is a 
out of sync management of the nand between at91sam9263 and the other 
at91sam9 chips : this could lead to misunderstanding for users.
I advice to modify nand management for all devices at the same time : 
9163 but also 9260, 9261, 9rl and all the relative boards.

Regards,
-- 
Nicolas Ferre


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php