Re: [PATCH] clean up access to locomo registers

[Thomas Kunze <thommycheck@xxxxxx>]

Dmitry Baryshkov wrote:
> Russell King - ARM Linux wrote:
>
>   
>> On Wed, Jul 23, 2008 at 04:17:11PM +0200, Thomas Kunze wrote:
>>     
>>> the locomo registers are accessed through ioremaped memory. Currently
>>> register read/writes use the locomo_readl/writel macros defined in
>>> include/asm-arm/hardware/locomo.h. This patch replaces the nonstandard
>>> locomo_readl/locomo_writel with the standard ioread16/iowrite16 calls.
>>> The conversion to 16 bit access is intended. The locomo registers have
>>> a size of 16 bit.
>>>       
>> As I've said elsewhere, the readw/writew interfaces aren't deprecated.
>> If you only support MMIO (which, if you're using only ioremap on
>> resources, that's the case) then there's absolutely no point using
>> io{read,write}*.
>>
>>     
>
> readw/writew aren't deprecated, however using direct memory access (like 
> locomo_readl/locomo_writel) surely is.

I also thought that direct memory access is not the right thing. I read in LDD3 that using
the readw/writew macros is discouraged. Can somebody explain when to use ioread/write and 
when not?
Should I resubmit the patch with readw/writew instead of ioread16/iowrite16?



-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php