Re: [PATCH 1/2] spitz.h rewritten and documented (resend)

[Eric Miao <eric.y.miao@xxxxxxxxx>]

Stanislav Brabec wrote:
> Stanislav Brabec wrote:
>> Attached patch adds description of the complete Spitz/Akita GPIO pinout
>> to the spitz.h, reorders the list into ascending order and drops
>> defines duplicating pxa2xx-gpio.h values.
>>
>> It's a source code only change not affecting compiled code.
>>
>> It's resend of my patch "[PATCH 2/2] pxa/spitz: spitz.h documentation and
>> rewrite" from Mon, 18 Feb 2008 18:42:09 +0100, which was not applied.
>> http://www.spinics.net/lists/arm-kernel/msg47470.html
> 
> If nobody complains, it is possible to accept this patch separately
> without PATCH 2/2.
> 
> This patch actually only provides full akita/spitz GPIO pinout
> documentation.
> 

Good comments about the usage of those pins.

As said, the first priority thing is to convert spitz into using the
newly proposed MFP API, and the table will just tell what each pin
is functioning as. So you can safely remove those comments about the
pins like UART and other configured pins with specific functions.

Leave comment only on those GPIOs that are really generic for
different purposes.

The Akita GPIO changes can actually be merged into a separate patch
converting from akita_{set,reset}_ioexp() to generic GPIO API.

And those direct accesses to PWER,PFER and PKWR are just horrible,
and those lines of code should be removed.

So, no, I won't accept a patch like this. What I need is several
separate patches, each addressing a specific issue, and the usage
of each pin can be added into each patch.

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php