Re: [PATCH 2/2] use symbolic names for spitz/pxa GPIOs (ported resend)

[Stanislav Brabec <utx@xxxxxxxxxx>]

Enrico Scholz wrote:
> Stanislav Brabec <utx@xxxxxxxxxx> writes:
> 
> > -		pxa_gpio_mode(113 | GPIO_OUT | GPIO_DFLT_HIGH); 
> > +		pxa_gpio_mode(GPIO113_AC97_RESET_N | GPIO_OUT | GPIO_DFLT_HIGH); 
> 
> When changing this, it should be changed completely and declare
> the used GPIO at some central place or (better) pass it through
> platform data (there is existing hardware which uses GPIO 95 as
> AC 97 reset pin).  E.g.

I was thinking about generic GPIO_AC97_RESET_N mapped somewhere to 113
as well.

I have been trying to create such table using the PXA27x documentation.
There are up to 7 meanings of each GPIO pin and 2-3 alternate GPIOs for
each meaning. There are several processor families and these tables can
differ model from model. Such generic mapping file would be a bit
complicated and untested for most combinations. That is why I gave it up
for now.

It may be an overkill, but it is possible to do it for particular
signals, whenever such need appears.

It is possible to use two approaches for it - compile time #if in
includes or a record in the platform bus. The first one will result in
simpler resulting code, the second one will allow to create a kernel
running on more devices (at least in theory).

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                          e-mail: sbrabec@xxxxxxx
Lihovarská 1060/12           tel: +420 284 028 966, +49 911 740538747
190 00 Praha 9                                  fax: +420 284 028 951
Czech Republic                                    http://www.suse.cz/


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php