Re: [PATCH 2/2] use symbolic names for spitz/pxa GPIOs (ported resend)

[Enrico Scholz <enrico.scholz@xxxxxxxxxxxxxxxxx>]

Stanislav Brabec <utx@xxxxxxxxxx> writes:

> -		pxa_gpio_mode(113 | GPIO_OUT | GPIO_DFLT_HIGH); 
> +		pxa_gpio_mode(GPIO113_AC97_RESET_N | GPIO_OUT | GPIO_DFLT_HIGH); 

When changing this, it should be changed completely and declare
the used GPIO at some central place or (better) pass it through
platform data (there is existing hardware which uses GPIO 95 as
AC 97 reset pin).  E.g.

#ifdef CONFIG_AC97_RESET_113
#  define AC97_RESET_GPIO 113
#  define AC97_RESET_MD   (113 | GPIO_ALT_FN_2_OUT)
#elif ...




Enrico


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php