Re: [PATCH 1/2] Device driver for Atmelintegratedtouchscreencontroller

[Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>]

Hi Dan,

On Mon, Jul 21, 2008 at 11:55:35AM +0200, Liang, Dan wrote:
> 
> 
> Dmitry Torokhov wrote:
> > > Hi Dmitry,
> > >
> > > >  - The device does not seem to support pressure reading so I will drop
> > > >    ABS_PRESSURE reporting.
> > >
> > > I tried to remove the faked pressure report and tested with tslib. But there is an error message:
> > > "selected device is not a touchscreen I understand". And the touch screen seems not to work properly.
> > >
> > >
> > 
> > This is the problem with tslib and I am hoping that someone will find
> > the time to fix it there.
> 
> Hi Dmitry,
> 
> To make the driver to work properly before someone fixs tslib,
> I wonder if the ABS_PRESSURE reporting could be kept for the
> moment.

Then nobody will ever fix it ;)

> Other driver like "drivers/input/touchscreen/ads7846.c" also fakes
> the pressure value for ads7843 chip.
> 

I will take patches correcting this.

> And another issue, could you please add the copyright in
> "drivers/input/touchscreen/atmel_tsadcc.c":
>  * Copyright (c) 2008 TimeSys Corporation
>  * Copyright (c) 2008 Justin Waters
> 

Will do.

-- 
Dmitry

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php