Re: [MFD] Patchset *UPDATED*

[Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>]

On Fri, Jul 18, 2008 at 05:08:17PM +0100, ian wrote:
> Hi folks,
> 
> Current state of the patches, please review.
> 
> There have been substantial changes, mostly regarding resource
> management, including one case where I found the NAND driver
> implementing its own version of platform_get_resource_by_name().
> 
> http://git.mnementh.co.uk/cgi-bin/gitweb.cgi?p=linux-2.6-im.git;a=shortlog;h=refs/heads/mfd_push_try_5


* retval -> ret.  Why?
* These lines from tmio_nand.c look bogus. Please get the correct resource
  and write values from it, not via mapped address.
+	iowrite16((unsigned long)tmio->fcr, tmio->ccr + CCR_BASE);
+	iowrite16((unsigned long)tmio->fcr >> 16, tmio->ccr + CCR_BASE + 16);
* Again, whitespace changes in t7l66xb.h. And while you are at it,
  please also either use tabs or no indent at all for resource
  initialisation in tc6387xb.c (and maybe in other places, didn't check).
* MMC driver is especially bad in terms of checkpatch.pl. Please look at
  it. Other patches can also get a bit of help from it.

-- 
With best wishes
Dmitry


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php