Re: [PATCH 4/5] pxa: poodle: convert to use the new GPIO API

[Richard Purdie <rpurdie@xxxxxxxxx>]

On Fri, 2008-07-18 at 09:14 +0800, eric miao wrote:
> From ac5a1491cdd0bbf84fcb8be78d290ad115f9aa92 Mon Sep 17 00:00:00 2001
> From: Eric Miao <eric.miao@xxxxxxxxxxx>
> Date: Fri, 18 Jul 2008 08:59:04 +0800
> Subject: [PATCH] pxa: poodle: convert to use the new GPIO API
> 
> Direct manipulation of GPIO registers are no longer encouraged, use
> the new GPIO API instead. Since the GPIO has to be requested before
> use, .startup and .shutdown are added to the IrDA device platform
> data to request and free the GPIO.
> 
> Signed-off-by: Eric Miao <eric.miao@xxxxxxxxxxx>
> ---
>  arch/arm/mach-pxa/poodle.c |   89 +++++++++++++++++++++++++++++++++++---------
>  1 files changed, 71 insertions(+), 18 deletions(-)
> 
[...]
> 
>  static int poodle_mci_get_ro(struct device *dev)
>  {
> +	return !!gpio_get_value(POODLE_GPIO_nSD_WP);
>  	return GPLR(POODLE_GPIO_nSD_WP) & GPIO_bit(POODLE_GPIO_nSD_WP);
>  }

You're missing a line deletion above, otherwise it looks ok.

Cheers,

Richard


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php