Re: [PATCH 1/5] pxa: poodle: remove unnecessary parent assignment to the fb device

[Richard Purdie <rpurdie@xxxxxxxxx>]

On Fri, 2008-07-18 at 09:12 +0800, eric miao wrote:
> This caused kref_get() to complain about incorrect kobject reference
> in set_pxa_fb_info(), due to the parent being registered later.
> 
> And is this necessary anyway?

This was present to ensure that the framebuffer was a child of the
locomo device. This ensured at suspend/resume that the framebuffer was
suspended first, then the locomo device. Have you tested suspend/resume?

> Signed-off-by: Eric Miao <eric.miao@xxxxxxxxxxx>
> ---
>  arch/arm/mach-pxa/poodle.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/poodle.c b/arch/arm/mach-pxa/poodle.c
> index 39612cf..c0eee5e 100644
> --- a/arch/arm/mach-pxa/poodle.c
> +++ b/arch/arm/mach-pxa/poodle.c
> @@ -380,7 +380,6 @@ static void __init poodle_init(void)
>    	GPSR1 = 0x00000000;
>          GPSR2 = 0x00000000;
> 
> -	set_pxa_fb_parent(&poodle_locomo_device.dev);
>  	set_pxa_fb_info(&poodle_fb_info);
>  	pxa_gpio_mode(POODLE_GPIO_USB_PULLUP | GPIO_OUT);
>  	pxa_gpio_mode(POODLE_GPIO_IR_ON | GPIO_OUT);


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php