Re: [PATCH 5/5] pxa: poodle: convert to use the new MFP API to configure pins

[Richard Purdie <rpurdie@xxxxxxxxx>]

On Fri, 2008-07-18 at 09:14 +0800, eric miao wrote:
> From f3a7f4194046e07e5c641fb97d991f53679d48d2 Mon Sep 17 00:00:00 2001
> From: Eric Miao <eric.miao@xxxxxxxxxxx>
> Date: Fri, 18 Jul 2008 09:05:17 +0800
> Subject: [PATCH] pxa: poodle: convert to use the new MFP API to configure pins
> 
> The MFP configuration table is reverse engineered from those
> magic GAFRx_{L|U} values, and it looks much better now.
> 
> Also, the deprecated pxa_gpio_mode() invocations are removed.
> 
> Signed-off-by: Eric Miao <eric.miao@xxxxxxxxxxx>

Sounds good in principle

> @@ -383,46 +439,11 @@ static void __init poodle_init(void)
>  	pm_power_off = poodle_poweroff;
>  	arm_pm_restart = poodle_restart;
> 
> -	/* setup sleep mode values */
> -	PWER  = 0x00000002;
> -	PFER  = 0x00000000;
> -	PRER  = 0x00000002;
> -	PGSR0 = 0x00008000;
> -	PGSR1 = 0x003F0202;
> -	PGSR2 = 0x0001C000;
>  	PCFR |= PCFR_OPDE;
> 
> -	/* cpu initialize */
> -	/* Pgsr Register */
> -  	PGSR0 = 0x0146dd80;
> -  	PGSR1 = 0x03bf0890;
> -  	PGSR2 = 0x0001c000;

but your patch doesn't cover setting up the sleep mode values so we
can't remove the bits above yet?

Cheers,

Richard


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php