Re: [MFD] Patchset *UPDATED*

[Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>]

On Thu, Jul 17, 2008 at 02:37:23AM +0100, ian wrote:
> All comments so far noted.
> 
> MMC debug is now a printk with KERN_DEBUG. I like it that way and unless
> theres a good reason its staying that way.
> 
> NAND has been unbroken and fixed properly
> 
> http://git.mnementh.co.uk/cgi-bin/gitweb.cgi?p=linux-2.6-im.git;a=shortlog;h=refs/heads/mfd_push_try_4

MMC driver suffers from explicit numbering of resources. Please use
platform_get_resource_byname/platform_get_irq. Also please set the
driver.owner field.

t7l66xb: please convert whitespace back to tabs in header file.
platform_get_irq returns -ERR on errors, not 0, please fix.

>  
> Im not implementing anything regarding register save / restore in
> TC6393XB until its determined why it fails on the sharp machines.
> 
> Either:
> 
> 1) The bootloader frigs it.
> 2) The hardware is broken.
> 
> The solution is potentially different in either case.
> 

-- 
With best wishes
Dmitry


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php