Re: [MFD] Patchset *UPDATED*

[Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>]

On Wed, Jul 16, 2008 at 10:13:18PM +0100, ian wrote:
> 
> Hi guys!
> 
> Here you can view a more polished version of the MFD TMIO patchset, now
> including the TC6393XB changes, since I have had time to verify that the
> chip does indeed behave properly on suspend / resume without the sharp
> specific hacks to store state.
> 
> This has been compiled and tested on T7L66XB and TC6393XB using
> machines. I havent got a TC6387XB based machine to hand for testing but
> so little changed in that driver that I would be stunned if it failed to
> work. It compiles cleanly.
> 
> I have also squashed two compile warnings from the NAND driver.

... and broke it's compilation with CONFIG_MTD_PARTITIONS, didn't you?

Also, in mmc driver usage of DBG looks bogus. pr_debug is compiled out
when no DEBUG is defined, so you get nothing from your macro. Please
drop it completely.

Checks for !irq should be probably replaced with (irq >= 0), since
get_irq returns -ENXIO in case of error.

As you've dropped the register save/restore from tc6393xb, please
export register names via the header file.

> http://git.mnementh.co.uk/cgi-bin/gitweb.cgi?p=linux-2.6-im.git;a=shortlog;h=refs/heads/mfd_push_try_3
> 
> Comments please!
> 

-- 
With best wishes
Dmitry


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php