Re: [PATCH v2 1/5] pinctrl: sunxi: Fix sunxi_irq_cfg_reg not working for irqs >= 8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 31, 2014 at 04:01:35PM +0200, Hans de Goede wrote:
> Rename SUNXI_IRQ_NUMBER to IRQ_PER_BANK as it no longer represents the total
> number of irqs and use it instead of the number of irqs-per-reg when
> calculating the bank to use for the various sunxi_irq_xxx_reg functions.
> This fixes sunxi_irq_cfg_reg using the wrong bank for irqs >= 8.
> 
> Also sunxi_irq_cfg_reg_from_bank returns the address of pio_int_cfg0, add an
> offset to the register returned for irqs living in the pio_int_cfg[1-3].
> 
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Good catch, I've squashed it into my serie with minor modifications
(remove the cfg_reg_from_bank that doesn't make any sense).

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: Digital signature

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [CentOS ARM]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]     [Photos]