Re: [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/04/2014 at 11:54:43 +0200, Alexandre Belloni wrote :
> Hi,
> 
> On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote :
> > +
> > +						vddana_reg: LDO_REG2 {
> > +							regulator-name = "VDDANA";
> > +							regulator-min-microvolt = <3300000>;
> > +							regulator-max-microvolt = <3300000>;
> > +							regulator-always-on;
> 
> I'm pretty sure that one is not always on as you actually have to
> configure it to get any voltage. Are you sure you want to set the
> regulator-always-on property here ?
> 

Just to clarify my though, wouldn't it be better to make the ADC driver
handle that regulator instead of using regulator-always-on ?

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [CentOS ARM]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]     [Photos]