Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 18, 2014 at 5:51 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> * Robert Nelson <robertcnelson@xxxxxxxxx> [140415 08:46]:
>> On Tue, Apr 15, 2014 at 10:35 AM, Nishanth Menon <nm@xxxxxx> wrote:
>> > On 04/15/2014 10:12 AM, Robert Nelson wrote:
>> >> On Tue, Apr 15, 2014 at 10:09 AM, Robert Nelson <robertcnelson@xxxxxxxxx> wrote:
>> >>> BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
>> >>>
>> >>> Signed-off-by: Robert Nelson <robertcnelson@xxxxxxxxx>
>> >>> ---
>> >>>  arch/arm/boot/dts/Makefile               |  1 +
>> >>>  arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
>> >>>  2 files changed, 16 insertions(+)
>> >>>  create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> >>>
>> >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> >>> index 35c146f..0bdeba3 100644
>> >>> --- a/arch/arm/boot/dts/Makefile
>> >>> +++ b/arch/arm/boot/dts/Makefile
>> >>> @@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
>> >>>         omap3-sbc-t3730.dtb \
>> >>>         omap3-devkit8000.dtb \
>> >>>         omap3-beagle-xm.dtb \
>> >>> +       omap3-beagle-xm-ab.dtb \
>> >>>         omap3-evm.dtb \
>> >>>         omap3-evm-37xx.dtb \
>> >>>         omap3-ldp.dtb \
>> >>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> >>> new file mode 100644
>> >>> index 0000000..9d81123
>> >>> --- /dev/null
>> >>> +++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> >>> @@ -0,0 +1,15 @@
>> >>> +/*
>> >>> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
>> >>> + *
>> >>> + * This program is free software; you can redistribute it and/or modify
>> >>> + * it under the terms of the GNU General Public License version 2 as
>> >>> + * published by the Free Software Foundation.
>> >>> + */
>> >>> +
>> >>> +#include "omap3-beagle-xm.dts"
>> >>> +
>> >>> +/ {
>> >>> +       /* HS USB Port 2 Power enable was inverted with the xM C */
>> >>> +       hsusb2_power: hsusb2_power_reg {
>> >>> +               enable-active-high;
>> >>        };
>> >>> +};
>> >>
>> >> Crap, copy paste bug, there.  I can send a v2, if you guys are happy
>> >> with the "omap3-beagle-xm-ab.dtb" naming..
>> >>
>> >> Regards,
>> >>
>> > Will u-boot adequately handle this as part of find_fdt?
>>
>> It will after i submit something like: (this uses a new feature in v2014.04)
>>
>> https://github.com/eewiki/u-boot-patches/blob/master/v2014.04/0001-am335x_evm-uEnv.txt-bootz-n-fixes.patch#L76
>>
>> Essentially, test for presence of omap3-beagle-xm-ab.dtb, if not found
>> drop to old omap3-beagle-xm.dtb
>>
>> Background: i also tried getting this having this fixed in u-boot:
>
> Do we still need to apply this patch then?

Yeah, Tom want's it done in the kernel:

Here's my proposed u-boot patch:
http://lists.denx.de/pipermail/u-boot/2014-January/172154.html

and Tom's recommendation:
http://lists.denx.de/pipermail/u-boot/2014-January/172274.html

Once this hits mainline, i'll submit a patch to u-boot to check for
the presence of this version and drop to the old dtb if not found.

Regards,

-- 
Robert Nelson
http://www.rcn-ee.com/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [CentOS ARM]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]     [Photos]