On Fri, 2014-02-07 at 10:49 +0000, Lee Jones wrote: > > Add Maxim 77836 support to max14577 driver. The chipsets have same MUIC > > component so the extcon, charger and regulators are almost the same. The > > max77836 however has also PMIC and Fuel Gauge. > > > > The MAX77836 uses three I2C slave addresses and has additional interrupts > > (related to PMIC and Fuel Gauge). It has also Interrupt Source register, > > just like MAX77686 and MAX77693. > > > > The MAX77836 PMIC's TOPSYS and INTSRC interrupts are reported in the > > PMIC block. The PMIC block has different I2C slave address and uses own > > regmap so another regmap_irq_chip is needed. > > > > Since we have two regmap_irq_chip, use shared interrupts on MAX77836. > > > > This patch adds additional defines and functions to the max14577 MFD core > > driver so the driver will handle both chipsets. Also this patch replaces > > "0x1 << N" with BIT(N) in defines for register masks. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > > Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > > My Ack is missing from this patch too. > > ... and probably all the others? How will I know which ones I've > already Acked without reviewing them all again? I already added your ACK-s to patches which got them. Unfortunately the numbering of patches changed because 4 of them were applied and 1 was dropped. This particular patch (previously: 13/18) haven't got you ACK because you've pointed some issues to fix. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel