On Wed, Jan 08, 2014 at 05:10:10PM +0000, Mark Brown wrote: [...] > diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c > new file mode 100644 > index 000000000000..853544f30a8b > --- /dev/null > +++ b/arch/arm64/kernel/topology.c > @@ -0,0 +1,92 @@ > +/* > + * arch/arm64/kernel/topology.c > + * > + * Copyright (C) 2011,2013 Linaro Limited. > + * > + * Based on the arm32 version written by Vincent Guittot in turn based on > + * arch/sh/kernel/topology.c > + * > + * This file is subject to the terms and conditions of the GNU General Public > + * License. See the file "COPYING" in the main directory of this archive > + * for more details. > + */ > + > +#include <linux/cpu.h> > +#include <linux/cpumask.h> > +#include <linux/init.h> > +#include <linux/percpu.h> > +#include <linux/node.h> > +#include <linux/nodemask.h> > +#include <linux/sched.h> > +#include <linux/slab.h> Nitpick, <linux/slab.h> does not belong in this patch. There are other includes that should be moved to the respective patch (percpu.h ?) where they are actually used. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel