Re: [PATCH 3/3] ARM: shmobile: Koelsch: Add QSPI support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

> <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> >> +       platform_device_register_resndata(&platform_bus, "qspi", 0,
> >
> >    As I understood, there's single QSPI controller, so why you pass 0, and
> > not -1 here?
> 
> Indeed, there's only a single QSPI instance.
> However, I choose to use "0" for consistency with Lager.
> Mach-shmobile seems to use a mix of 0 and -1.
> 
> If the maintainer prefers -1, I can change that.

In SPI driver case, spi master will use dynamic 
bus_num value if ID was -1 (in spi_register_master()).
Then, slave device can't be detected.
So, ID = 0 is reasonable even though single QSPI.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [CentOS ARM]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]     [Photos]