I have resent the patch with an issue regarding the NAND device. Sorry that it took so long... On Fri, Dec 20, 2013 at 4:09 AM, Jason Cooper <jason@xxxxxxxxxxxxxx> wrote: > On Sat, Dec 07, 2013 at 07:56:52PM -0500, Jason Cooper wrote: >> On Sun, Nov 24, 2013 at 12:13:19PM -0500, Jason Cooper wrote: >> > On Sun, Nov 17, 2013 at 02:20:53PM +0100, Sebastian Hesselbarth wrote: >> > > On 11/16/2013 11:08 PM, Maxime Hadjinlian wrote: >> > > >This patch adds DT board setup for the LaCie NAS LaPlug. >> > > >> > > [adding MVEBU maintainers, please do that always from now on] >> > > >> > > Maxime, >> > > >> > > first of all, thanks for providing this. Anyway, I do have some >> > > remarks below. >> > > >> > > >Chipset list: >> > > >- CPU MARVELL 88FR131 800Mhz >> > > >- SDRAM memory: 128MB DDR2-800 400Mhz >> > > >- 1 Ethernet Gigabit port (PHY MARVELL 88E1318) >> > > >- 1 Mini PCI-Express port >> > > >- 1 NAND 512 MB >> > > >- 1 push button >> > > >- 2 LEDs (red and blue) >> > > >- 4 USB Ports >> > > > >> > > >Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@xxxxxxxxx> >> > > >--- >> > > > arch/arm/boot/dts/Makefile | 1 + >> > > > arch/arm/boot/dts/kirkwood-nsplug.dts | 178 ++++++++++++++++++++++++++++++++++ >> > > > 2 files changed, 179 insertions(+) >> > > > create mode 100644 arch/arm/boot/dts/kirkwood-nsplug.dts >> > ... >> > > >+&mdio { >> > > >+ status = "okay"; >> > > >+ >> > > >+ ethphy0: ethernet-phy@0 { >> > > >+ device_type = "ethernet-phy"; >> > > >> > > If you know the type of PHY used here, please add >> > > a compatible like "marvell,88e1318s" >> > >> > Please be aware of the current conversation [1] started by Jason >> > Gunthorpe regarding the compatible string choice here. Once that's >> > resolved, please resend. >> >> Looks like we chose to dodge the issue. Mind resending with the >> a comment identifying the phy? > > Well, I was going to take this version and fix up the phy node, but > re-reading the thread I see there were quite a few comments that were > never addressed. Please resend a V2 if you'd like to add support for > this board. > > thx, > > Jason. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel