Re: [PATCH v12 05/08] ARM: hi3xxx: add smp support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Haojian Zhuang <haojian.zhuang@xxxxxxxxxx> writes:

> From: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
>
> Enable SMP support on hi3xxx platform
>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
> Tested-by: Zhang Mingjun <zhang.mingjun@xxxxxxxxxx>
> Tested-by: Li Xin <li.xin@xxxxxxxxxx>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@xxxxxxxxxx>

This one has checkpatch errors too:

ERROR: do not initialise statics to 0 or NULL
#267: FILE: arch/arm/mach-hi3xxx/platsmp.c:20:
+static void __iomem *ctrl_base = NULL;

ERROR: space prohibited before that close parenthesis ')'
#282: FILE: arch/arm/mach-hi3xxx/platsmp.c:35:
+	return readl_relaxed(ctrl_base + ((cpu - 1 ) << 2));

I fixed these up locally too, but my generosity is running out.

Kevin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [CentOS ARM]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]     [Photos]