|
|
Re: [PATCH 10/11] spi/s3c64xx: improve error handling |
On Friday 10 August 2012, Kukjin Kim wrote: > BTW for same reason, probably, we need following fix? > > arch/arm/mach-tegra/tegra2_emc.c | 4 ++-- > arch/c6x/kernel/setup.c | 2 +- > arch/powerpc/kernel/ibmebus.c | 2 +- > arch/powerpc/kernel/pci_of_scan.c | 2 +- > arch/powerpc/kernel/prom.c | 2 +- > arch/powerpc/kernel/rtas_pci.c | 2 +- > arch/powerpc/kernel/vio.c | 2 +- > arch/powerpc/platforms/44x/warp.c | 2 +- > ... Actually not. The difference is that only s3c64xx_get_slave_ctrldata accesses the node pointer outside of the look (after break). This fails when there are no child nodes at all. In the other cases, the only use of the node pointer is inside the loop, where it is guaranteed to be valid. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [PDAs] [Linux] [Linux MIPS] [Yosemite Campsites] [Photos]
![]() |
![]() |