RE: [PATCH 1/1] ARM: OMAP2+: hwmod: Print an error message if no match exists for a hwmod class

["Bedia, Vaibhav" <vaibhav.bedia@xxxxxx>]

Hi Paul,

On Wed, Aug 08, 2012 at 19:35:50, Paul Walmsley wrote:
[...]
> It doesn't seem to me that this would necessarily always be an error.  
> Suppose some init code to create cpsw devices is running on an OMAP3430.  
> Then a omap_hwmod_for_each_by_class() that doesn't locate anything 
> wouldn't be an error, right?
> 

Well, I think a failed lookup operation will be a bit expensive since it
iterates over the whole list of registered hwmods and hence put in the
pr_err(). But I don't see how the SoC specific example that you pointed out
could be handled without putting in cpu_is_* checks in the registration
process itself :(

Would a pr_debug() be ok?

Regards,
Vaibhav B.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel